Skip to content

chore: add rockwoodleadership urls to html_proofer ignores #3413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

chore: add rockwoodleadership urls to html_proofer ignores #3413

merged 1 commit into from
Apr 10, 2025

Conversation

jmeridth
Copy link
Member

  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Currently PRs are failing tests because rockwoodleadership.com URLs are 403ing.

@jmeridth
chore: add rockwoodleadership urls to html_proofer ignores
1792547 
Signed-off-by: jmeridth <jmeridth@gmail.com>
@jmeridth jmeridth self-assigned this Apr 10, 2025
@Copilot Copilot AI review requested due to automatic review settings April 10, 2025 04:19
@jmeridth jmeridth requested a review from a team as a code owner April 10, 2025 04:19
Copilot
Copilot AI reviewed Apr 10, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new URL pattern to the HTMLProofer ignore list in order to bypass failing tests for rockwoodleadership URLs.

  • Added a new regex to ignore rockwoodleadership URLs
  • Aimed at preventing 403 errors in the test runs

@jmeridth jmeridth merged commit 4c93361 into main Apr 10, 2025
7 checks passed
@jmeridth jmeridth deleted the jm_ignore_rockwoodleadership_urls branch April 10, 2025 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot

Assignees

@jmeridth jmeridth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jmeridth