Embed the Dockerfile #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonovan
reviewed
Jan 10, 2022
Contributor
adonovan
left a comment
adonovan
left a comment
There was a problem hiding this comment.
I don't have strong feelings either way, but I'm not sure this change adds much: the string constant was perfectly clear (notably, it's not as if it had any burden of escape sequences) and was defined close to its point of use, making the whole program visible at a glance.
Contributor
Author
|
I like the idea of being able to build the Dockerfile locally to use/test without running the entire Go program. I understand the "visible at a glance" argument though, and I'll defer to your judgement. |
Contributor
OK, that's a reason. LGTM. |
adonovan
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at #3 I felt like we had an opportunity to retain typing/syntax help from our editors for our Dockerfile if we used Go's embed package. This PR does so!