Skip to content

Use install > get as it will stop building bins #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2022

Conversation

marwan-at-work
Copy link
Contributor

Though at this point we still use Go 1.17, 1.18 release notes say:

go get no longer builds or installs packages in module-aware mode

Ref: https://tip.golang.org/doc/go1.18

Also, I've never done go install <mod1> <mod2> but trying it locally, I need to make sure to run both of them separately otherwise Go thinks <mod2> must belong to <mod1>

$ go install google.golang.org/protobuf/cmd/protoc-gen-go@latest github.com/twitchtv/twirp/protoc-gen-twirp@latest
go: finding module for package github.com/twitchtv/twirp/protoc-gen-twirp
go: finding module for package github.com/pkg/errors
go: found github.com/pkg/errors in github.com/pkg/errors v0.9.1
package github.com/twitchtv/twirp/protoc-gen-twirp provided by module github.com/twitchtv/twirp@v8.1.1+incompatible
	All packages must be provided by the same module (google.golang.org/protobuf@v1.27.1)

vs

$ go install google.golang.org/protobuf/cmd/protoc-gen-go@latest && go install github.com/twitchtv/twirp/protoc-gen-twirp@latest
go: finding module for package github.com/pkg/errors
go: finding module for package google.golang.org/protobuf/types/pluginpb
go: finding module for package google.golang.org/protobuf/proto
go: finding module for package google.golang.org/protobuf/types/descriptorpb
go: found github.com/pkg/errors in github.com/pkg/errors v0.9.1
go: found google.golang.org/protobuf/proto in google.golang.org/protobuf v1.27.1
go: found google.golang.org/protobuf/types/descriptorpb in google.golang.org/protobuf v1.27.1
go: found google.golang.org/protobuf/types/pluginpb in google.golang.org/protobuf v1.27.1

Though at this point we still use Go 1.17, 1.18 release notes say: 

> go get no longer builds or installs packages in module-aware mode

Ref: https://tip.golang.org/doc/go1.18
@marwan-at-work marwan-at-work merged commit a8ef123 into main Mar 1, 2022
@marwan-at-work marwan-at-work deleted the marwan-at-work-patch-1 branch March 1, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants