-
Notifications
You must be signed in to change notification settings - Fork 202
Remote queries view using mock data #1023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome!
Looks smashing! Can I suggest a tiny change of wording to "Summary: 13 repositories affected". It's quite common for users to write queries that are meant to explore a code base. For such queries, the term "affected" might sound a bit odd. And the number "13" is already mentioned in the text just above it. So how about rewording "Summary: 13 repositories affected" to "Repositories with results (13)" or something like that? @nuthinking and @jf205 might have better ideas! |
Thanks @sj, I've gone ahead and made the change but we can also make further tweaks later on. |
I know that we already show the number above in small but, also for consistency with the results header, I'd rather go for |
This changeset builds up an initial remote queries view based on some mock data. The view will gradually be refined and hooked into real data with further PRs.
See internal issue for more context.
Checklist
N/A: This is only relevant for remote queries, which is still an internal-only feature.
@github/docs-content-codeql
has been cc'd in all issues for UI or other user-facing changes made by this pull request.