Skip to content

Improve error handling for CLI installation and updates #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2019
Merged

Improve error handling for CLI installation and updates #177

merged 1 commit into from
Nov 25, 2019

Conversation

henrymercer
Copy link
Contributor

  • Add a specific error message when the user has been rate limited which specifies when the rate limiting resets.
  • If an error occurs while updating the CLI during an automatic update check, this will be displayed as a warning rather than an error as it is non-critical.
  • Remove the link to edit the settings when we encounter a GitHub API error, since we no longer have any settings that could be related to these errors.
  • Error messages take into account the specific task.

Am very much open to better names for ReportingConfig

@henrymercer
Report rate limiting errors more clearly
b48fbde 
Also report problems updating the distribution on extension activation
as warnings, and improve task names in error messages.
@alexet alexet merged commit 6e9c64d into github:master Nov 25, 2019
@henrymercer henrymercer deleted the improve-errors branch November 25, 2019 14:34
@snyk-bot snyk-bot mentioned this pull request Apr 22, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexet alexet alexet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrymercer @alexet