Split queries #185
Closed
Split queries #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 6 alerts when merging 4e2ea61 into e056c61 - view on LGTM.com new alerts:
|
alexet
force-pushed
the
split-queries
branch
from
4e2ea61 to
8f6400f
Compare
|
This pull request introduces 3 alerts when merging 8f6400f into e056c61 - view on LGTM.com new alerts:
|
alexet
force-pushed
the
split-queries
branch
from
8f6400f to
62c1243
Compare
alexet
force-pushed
the
split-queries
branch
from
62c1243 to
c6e880e
Compare
|
This code effectively landed in #222. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split up query running, upgrade running, and operations on queries post run. The main point is clearly separating which state is post query run state (such as the locations of the sorted results) compared to the immutable results of running the query.