Skip to content

Conversation

charisk
Copy link
Contributor

@charisk charisk commented Dec 23, 2022

Moved data and data2 directories that are only used by the file.test.ts into a directory specific to those tests.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from a team December 23, 2022 12:02
@charisk charisk requested a review from a team as a code owner December 23, 2022 12:02
Copy link
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test/data directory is also used by the minimal-workspace and cli-integration tests, so I don't think we can actually move these without affecting those tests.

Because those two suites are also using them, test/data is probably the best path they can be in. I don't think we should move them to the pure-tests directory.

@charisk
Copy link
Contributor Author

charisk commented Dec 23, 2022

The test/data directory is also used by the minimal-workspace and cli-integration tests, so I don't think we can actually move these without affecting those tests.

Because those two suites are also using them, test/data is probably the best path they can be in. I don't think we should move them to the pure-tests directory.

You're right, I only just realised - didn't run integration tests locally.

@charisk charisk closed this Dec 23, 2022
@charisk charisk deleted the charisk/move-test-data-closer branch March 9, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants