fix: Alignment of alerts row in query view #308
Conversation
There was a problem hiding this comment.
I'm still seeing a slightly higher baseline for the results predicate dropdown after this PR:
Is the problem perhaps instead due to the vertical-align: middle alignment given to .vscode-codeql__result-table-toggle-diagnostics label and .vscode-codeql__result-table-toggle-diagnostics input?
|
Yeah, I lean towards thinking that fixing the underlying choice of alignment is preferable to pixel hacking in this case? |
I'll look at that too. Looks like it's less than a pixel. I'll try playing around with the |
aeisenberg
force-pushed
the
aeisenberg/alignment
branch
from
8ac7b54 to
eef5dc7
Compare
|
The problem is that there is a misalignment is between the select and the span (the leftmost two elements on the row). The classes that you mention, @henrymercer only apply to the input and the label on the right. Even if I change the So, I came up with something that seems to work ok. It's more complex than before |
|
@aeisenberg Are you able to repro locally? I still seem to be getting misalignment when I check out your PR:
I wonder whether what we really want is all the text above the results table to be vertically aligned with the middle of the checkbox. I don't know whether that's achievable nicely (one option could just be reverting to your original implementation) but does that sound like the right goal? |
|
Hmmm...I'm seeing something different with the latest of this PR. As far as I can tell, the row is completely aligned. Not sure what the difference is. Are you on Linux? I'm on mac. Is this issue a big concern for you? I've already spent more than an hour on this and I'm not sure if it is worth my time to spend much more.
|
I'm on Mac as well
No definitely not, it's a nit. |
|
@jcreedcmu would you be able to try this out on your linux machine and see whether you can reproduce? Though, I also recommend not spending much more time on this since there are other things to work on. |
|
Going to close this unless we can come to some sort of consensus or conclusion here. |
fixes #237.