Skip to content

Fix dependabot vulnerability #3781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg requested a review from a team as a code owner October 29, 2024 16:46
Copy link
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this actually fixes the vulnerability since both express and @bundled-es-modules/cookie still depend on a different (vulnerable) version of cookie:

  • "node_modules/@bundled-es-modules/cookie/node_modules/cookie": {
    "version": "0.5.0",
    "resolved": "https://registry.npmjs.org/cookie/-/cookie-0.5.0.tgz",
    "integrity": "sha512-YZ3GUyn/o8gfKJlnlX7g7xq4gyO6OSuhGPKaaGssGB2qgDUS0gPgtTvoyZLTt9Ab6dC4hfc9dV5arkvc/OCmrw==",
    "engines": {
    "node": ">= 0.6"
    }
    },
  • "node_modules/express/node_modules/cookie": {
    "version": "0.6.0",
    "resolved": "https://registry.npmjs.org/cookie/-/cookie-0.6.0.tgz",
    "integrity": "sha512-U71cyTamuh1CRNCfpGY6to28lxvNwPG4Guz/EVjgf3Jmzv0vlDp1atT9eS5dDjMYHucpHbWns6Lwf3BKz6svdw==",
    "dev": true,
    "engines": {
    "node": ">= 0.6"
    }
    },

I think we will need to wait for upstream to update before this vulnerability can be fixed. This will just include a different (unused) version of cookie, in addition to the vulnerable versions. We are tracking this vulnerability already (see internal linked issue).

@aeisenberg
Copy link
Contributor Author

Thanks. I'll close this since it's not a path worth going down.

@aeisenberg aeisenberg closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants