Remove pull_request from actions #404
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@adityasharad informed me in github#403 that it is not yet supported.
jcreedcmu
force-pushed
the
jcreed/irrelevant
branch
from
8fe17a1 to
1af7582
Compare
jcreedcmu
changed the title
aeisenberg
requested changes
May 27, 2020
.github/workflows/main.yml
Outdated
| @@ -1,5 +1,5 @@ | |||
| name: Build Extension | |||
| on: [push, pull_request] | |||
| on: push | |||
There was a problem hiding this comment.
Are we sure we want to do this? And if we do, we need this:
on: [push]
or
on:
push:
|
The motivation for doing it was @adityasharad saying pull_request wasn't supported. You're correct about my yaml error, though, will fix. |
|
It's only not supported for the codeql action. It is fine for the checks action and ensures that the tests are run on PRs from users who haven't enabled actions on their fork. |
|
Ah, ok, so I misunderstood that, then. Closing as this is no longer necessary. |
|
You may still want to delete it from |
|
Correct; but #405 is already doing that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.