Use the correct environment variable in integration tests #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityasharad
reviewed
Nov 3, 2021
CONTRIBUTING.md
Outdated
| Ensure the `CODEQL_PATH` environment variable is set to point to the `codeql` cli executable. | ||
|
|
||
| Outside of vscode, run: | ||
| Unit tests and many integration tests do not Outside of vscode, run: |
There was a problem hiding this comment.
Suggested change
| Unit tests and many integration tests do not Outside of vscode, run: | |
| Unit tests and many integration tests do not require a copy of the CodeQL CLI. Outside of vscode, run: |
| @@ -122,13 +122,12 @@ jobs: | |||
| working-directory: extensions/ql-vscode | |||
| if: matrix.os == 'ubuntu-latest' | |||
| run: | | |||
| CODEQL_PATH=$GITHUB_WORKSPACE/codeql-home/codeql/codeql npm run test | |||
There was a problem hiding this comment.
So these tests are not using the CLI? Should we remove it from being installed in the step above?
There was a problem hiding this comment.
They may have at one point in the past, but not any more. I will remove the section.
aeisenberg
force-pushed
the
aeisenberg/env-var
branch
from
0d6c190 to
37793b2
Compare
Also, fix documentation and launch configs to specify the correct and complete set of environment variables we should be using.
aeisenberg
force-pushed
the
aeisenberg/env-var
branch
from
37793b2 to
649887d
Compare
adityasharad
approved these changes
Nov 3, 2021
|
Updated the branch protection rules for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, fix documentation and launch configs to specify the correct and
complete set of environment variables we should be using.
This should fix the failing integration tests on our internal repository.
Replace this with a description of the changes your pull request makes.
Checklist
@github/docs-content-codeqlhas been cc'd in all issues for UI or other user-facing changes made by this pull request.