-
Notifications
You must be signed in to change notification settings - Fork 73
fix: 🐛 syntax error on multiline class constant with comment #1152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
czosel
merged 4 commits into
glayzzle:main
from
shufo:fix/multiline_class_constant_with_comment
Jun 27, 2025
Merged
fix: 🐛 syntax error on multiline class constant with comment #1152
czosel
merged 4 commits into
glayzzle:main
from
shufo:fix/multiline_class_constant_with_comment
Jun 27, 2025
+96
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests has passed but seems benchmark failed. I don't know it's ok to failed.
|
claytonrcarter
added a commit
to claytonrcarter/plugin-php
that referenced
this pull request
Apr 18, 2025
This is a feature regression, but it's needed to workaround a defect in php-parser introduced in v3.2.2. I feel like this is an acceptable regression that we can un-regress once the pending fix is merged and released in php-parser. Ref: glayzzle/php-parser#1152
b7ff101
to
0965288
Compare
czosel
approved these changes
Jun 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0965288
to
5d09ee6
Compare
Released in |
cseufert
pushed a commit
to claytonrcarter/plugin-php
that referenced
this pull request
Jul 9, 2025
This is a feature regression, but it's needed to workaround a defect in php-parser introduced in v3.2.2. I feel like this is an acceptable regression that we can un-regress once the pending fix is merged and released in php-parser. Ref: glayzzle/php-parser#1152
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Problem
Solution
Skip comments and whitespace when peeking as peek() is just peeking next token without consider comment. I don't know this is proper solution but it works as expected in my environment.