Fix the linter #262
Open
Fix the linter #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanluisvaladas
force-pushed
the
fix-linter
branch
from
0bd9fde to
b1b8343
Compare
Golangci-lint <1.58.0 doesn't work because mdm, and >=1.58.0 have several linter issues. I tried older versions of golang too but I couldn't find a working combination. Lint has been broken for a while, merge this as is and fix the linting issues in separate PR. Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <jvaladas@mirantis.com>
Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <jvaladas@mirantis.com>
Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <jvaladas@mirantis.com>
juanluisvaladas
force-pushed
the
fix-linter
branch
from
b1b8343 to
4b08856
Compare
Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <jvaladas@mirantis.com>
juanluisvaladas
force-pushed
the
fix-linter
branch
from
be5f2c5 to
385588c
Compare
|
The failing steps of the CI are unrelated to this change and need to be fixed in a separate PR: #263 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linter has been broken for a few months now. This PR fixes it.
The linter now runs on a container so that it always gives consistent linting, it's an adaptation of how we do it on k0s.
I wanted to upgrade to golangci-lint 2 but I think this PR is already quite big so I'm splitting it into 2 PRs.