Skip to content

test does not validate the name of PRR approver correctly #5422

Open
@SergeyKanzhelev

Description

@SergeyKanzhelev

See #5421 (comment)

For some reason #5308 was merged without test failure with the name of PRR approver containing extra whitespace.

Then tests starting failing like here: https://prow.k8s.io/pr-history/?org=kubernetes&repo=enhancements&pr=5421 with the error message:

this contributor ( wojtek-t) is not a PRR approver ([deads2k ehashman johnbelamaric jpbetz soltysh wojtek-t])"

(not the whitespace before the wojtek-t name.

Ideally the validation whould have failed on #5308

/help

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.needs-sigIndicates an issue or PR lacks a `sig/foo` label and requires one.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions