Skip to content

Improve agent payload validation #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jul 8, 2025
Merged

Improve agent payload validation #202

merged 19 commits into from
Jul 8, 2025

Conversation

jamesdangercarpenter
Copy link
Collaborator

@jamesdangercarpenter jamesdangercarpenter commented Jun 27, 2025 •
edited
Loading

Relaxes the Package->Agent payload validation, to allow different versions of the package and agent to co-exist, as long as their payload version matches.

Validates that the NIGHTWATCH_TOKEN used to create the payload matches the one specified in the agent, to prevent attribution of events to an incorrect environment.

@jamesdangercarpenter jamesdangercarpenter changed the title Feat/use payload signature Use payload signature Jun 27, 2025
@jamesdangercarpenter jamesdangercarpenter force-pushed the feat/use-payload-signature branch from 0c05138 to 607431f Compare June 27, 2025 07:37
@jamesdangercarpenter jamesdangercarpenter marked this pull request as draft June 27, 2025 07:37
@jamesdangercarpenter jamesdangercarpenter force-pushed the feat/use-payload-signature branch 5 times, most recently from 8500b7b to 3eeb004 Compare July 3, 2025 14:43
@jamesdangercarpenter jamesdangercarpenter changed the title Use payload signature use payload signature Jul 3, 2025
@jamesdangercarpenter jamesdangercarpenter force-pushed the feat/use-payload-signature branch 5 times, most recently from 182671b to 1ebf7ef Compare July 8, 2025 05:12
@jamesdangercarpenter jamesdangercarpenter changed the title use payload signature Refactor agent payload validation Jul 8, 2025
@jamesdangercarpenter jamesdangercarpenter changed the title Refactor agent payload validation Improve agent payload validation Jul 8, 2025
@jamesdangercarpenter jamesdangercarpenter marked this pull request as ready for review July 8, 2025 05:13
timacdonald
timacdonald reviewed Jul 8, 2025
View reviewed changes
timacdonald
timacdonald reviewed Jul 8, 2025
View reviewed changes
timacdonald
timacdonald reviewed Jul 8, 2025
View reviewed changes
timacdonald
timacdonald reviewed Jul 8, 2025
View reviewed changes
timacdonald
timacdonald reviewed Jul 8, 2025
View reviewed changes
timacdonald
timacdonald reviewed Jul 8, 2025
View reviewed changes
timacdonald
timacdonald reviewed Jul 8, 2025
View reviewed changes
timacdonald
timacdonald reviewed Jul 8, 2025
View reviewed changes
timacdonald
timacdonald reviewed Jul 8, 2025
View reviewed changes
timacdonald
timacdonald reviewed Jul 8, 2025
View reviewed changes
timacdonald
timacdonald reviewed Jul 8, 2025
View reviewed changes
timacdonald
timacdonald reviewed Jul 8, 2025
View reviewed changes
@jamesdangercarpenter jamesdangercarpenter force-pushed the feat/use-payload-signature branch from 5134d18 to 8946c33 Compare July 8, 2025 06:04
jamesdangercarpenter and others added 17 commits July 8, 2025 16:06
@jamesdangercarpenter
feat: use payload signature in place of build signature
c727e69
@jamesdangercarpenter
fix: update payload version on push to 1.x, to maintain proper change…
51da1b0 
… detection
@jamesdangercarpenter
chore: use a static payload version rather than a signature
074253a
@github-actions @jamesdangercarpenter
feat: validate token hash between package/agent Refs: NW-1106
1c26c31
@github-actions @jamesdangercarpenter
Bump agent version to 8C4DC53C7E7D4F7E83C103E83E05D166F30E69B389EEE5B…
8779ef6 
…29C690A139E6F69BFD01E376E160B0F69E209A6C8B8809C848DBC1839B7FC7609080CBBEF356DE9EC
@jamesdangercarpenter
chore: update tests
31e45ad
@jamesdangercarpenter
chore: remove redundant version_payload.yml workflow
ccd019c
@github-actions @jamesdangercarpenter
Fix code styling
67d4ffd
@jamesdangercarpenter
fix: remove redundant test
0cc1b9b
@jamesdangercarpenter
chore: use const for payload version
7f268f3
@jamesdangercarpenter
chore: pass tokenHash from provider
99910cf
@jamesdangercarpenter
fix: linting
2da0dc8
@jamesdangercarpenter
fix: ignore dependency validation for Laravel\NightwatchAgent\Payload
48246b9
@jamesdangercarpenter
chore: remove orphaned file
095a986
@jamesdangercarpenter
chore: rename agent payload constant
cb6d878
@jamesdangercarpenter
chore: ignore phpstan error conditionally
5a8362b
@jamesdangercarpenter
address PR feedback
3d1ac4d
@jamesdangercarpenter jamesdangercarpenter force-pushed the feat/use-payload-signature branch from 8946c33 to 3d1ac4d Compare July 8, 2025 06:07
@jamesdangercarpenter jamesdangercarpenter force-pushed the feat/use-payload-signature branch from 72f4224 to debcd26 Compare July 8, 2025 06:20
@github-actions
Bump agent version to C8DB9D7EE8A6DB35E416926A3FDE38AA5913E0637CB7D83…
b8c9d95 
…3DA0ABA38E5C1A1F7E6FB927AC4CA67C658BC6B5ED819DDBD99B1C9B29A7B74E10D138D73FFAA03FC
@jamesdangercarpenter jamesdangercarpenter merged commit 9048f92 into 1.x Jul 8, 2025
25 checks passed
@jamesdangercarpenter jamesdangercarpenter deleted the feat/use-payload-signature branch July 8, 2025 06:36
@jamesdangercarpenter jamesdangercarpenter mentioned this pull request Jul 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timacdonald timacdonald timacdonald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesdangercarpenter @timacdonald