Downgrade of paypal/module-braintree when updating to 2.4.8-p1 from 2.4.8

[nomis11uk]

Preconditions and environment

When we update from 2.4.8 to 2.4.8-p1 the following packages are downgraded:

• Downgrading paypal/module-braintree-core (4.7.0 => 4.6.1-p5): Extracting archive
• Downgrading paypal/module-braintree-graph-ql (4.7.0 => 4.6.1-p5): Extracting archive
• Downgrading paypal/module-braintree-gift-wrapping (4.7.0 => 4.6.1-p5): Extracting archive
• Downgrading paypal/module-braintree-gift-card-account (4.7.0 => 4.6.1-p5): Extracting archive
• Downgrading paypal/module-braintree-customer-balance (4.7.0 => 4.6.1-p5): Extracting archive
• Downgrading paypal/module-braintree (4.7.0 => 4.6.1-p5)

Steps to reproduce

Update from 2.4.8 to 2.4.8-p1

Expected result

Packages paypal/module-braintree should not be downgraded

Actual result

Packages paypal/module-braintree are downgraded

• Downgrading paypal/module-braintree-core (4.7.0 => 4.6.1-p5): Extracting archive
• Downgrading paypal/module-braintree-graph-ql (4.7.0 => 4.6.1-p5): Extracting archive
• Downgrading paypal/module-braintree-gift-wrapping (4.7.0 => 4.6.1-p5): Extracting archive
• Downgrading paypal/module-braintree-gift-card-account (4.7.0 => 4.6.1-p5): Extracting archive
• Downgrading paypal/module-braintree-customer-balance (4.7.0 => 4.6.1-p5): Extracting archive
• Downgrading paypal/module-braintree (4.7.0 => 4.6.1-p5)

Additional information

No response

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @nomis11uk. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[hostep]

That's strange, for me it stays at version 4.7.0 (on a vanilla install).

Can you try to figure out why composer thinks it should install version 4.6.1-p5?

Here's how you can try to figure it out (this is my output on 2.4.8-p1 vanilla):

$ composer why -r paypal/module-braintree
magento/project-community-edition        2.4.8-p1 requires magento/product-community-edition (2.4.8-p1)
magento/product-community-edition        2.4.8-p1 requires adobe-commerce/os-extensions-metapackage (^1.0.1)
adobe-commerce/os-extensions-metapackage 1.0.1    requires paypal/module-braintree (>=4.7.0@beta <5.0.0)

(this sounds like it may cause this other issue that was reported yesterday: #39980)

[n2diving-dgx]

Confirmed for my M2.4.8 installation... when I update to M2.4.8-p1 the braintree module DOWNGRADES from v4.7.0 (for Magento 2.4.8) to v.4.6.1 (for Magento v2.4.7) Which does indeed break Braintree in my installation (the fixes in 4.7.0 are needed.) See screen shot below...

Braintree Version 4.6.1 is not supported for Magneto Version 2.4.8, see release notes

https://support.gene.co.uk/support/solutions/articles/35000228529-braintree-release-notes-for-v4-6-1-adobe-commerce-magento-open-source-v2-4-7-

https://support.gene.co.uk/support/solutions/articles/35000278668-braintree-release-notes-for-v4-7-0-adobe-commerce-magento-open-source-v2-4-8-

$ php bin/magento -V
Magento CLI 2.4.8-p1
$ composer why -r paypal/module-braintree
magento/project-community-edition - requires magento/product-community-edition (2.4.8-p1)
magento/product-community-edition 2.4.8-p1 requires adobe-commerce/os-extensions-metapackage (^1.0.1)
magento/project-community-edition - requires paypal/module-braintree (^4.6)
adobe-commerce/os-extensions-metapackage 1.0.1-p1 requires paypal/module-braintree (~4.6.1)

Comparing to 2.4.8 we see...

$ php bin/magento -V
Magento CLI 2.4.8
$ composer why -r paypal/module-braintree
magento/project-community-edition - requires magento/product-community-edition (2.4.8)
magento/product-community-edition 2.4.8 requires adobe-commerce/os-extensions-metapackage (1.0.1)
adobe-commerce/os-extensions-metapackage 1.0.1 requires paypal/module-braintree (>=4.7.0@beta <5.0.0)

Attempting to force Braintree 4.7.0 on Magneto 2.4.8-p1 fails...

$ composer require paypal/module-braintree:^4.7 --with-all-dependencies
./composer.json has been updated
Running composer update paypal/module-braintree --with-all-dependencies
Gathering patches for root package.
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

Problem 1
- Root composer.json requires paypal/module-braintree ^4.7, found paypal/module-braintree[4.7.0] but these were not loaded, likely because it conflicts with another require.
Problem 2
- magento/product-community-edition is locked to version 2.4.8-p1 and an update of this package was not requested.
- adobe-commerce/os-extensions-metapackage 1.0.1-p1 requires paypal/module-braintree ~4.6.1 -> found paypal/module-braintree[4.6.1, 4.6.1-p1, 4.6.1-p3, 4.6.1-p5] but it conflicts with your root composer.json require (^4.7).
- magento/product-community-edition 2.4.8-p1 requires adobe-commerce/os-extensions-metapackage ^1.0.1 -> satisfiable by adobe-commerce/os-extensions-metapackage[1.0.1-p1].

Installation failed, reverting ./composer.json and ./composer.lock to their original content.

[hostep]

@n2diving-dgx: one thing that is odd, is that you have version 1.0.1-p1 installed of adobe-commerce/os-extensions-metapackage, which indeed seems to require paypal/module-braintree ~4.6.1.

What I'm seeing in Magento 2.4.8-p1 (and 2.4.8) is that adobe-commerce/os-extensions-metapackage should be at version 1.0.1, that one has the correct dependency definition for paypal/module-braintree

Can you try to up/down-grade adobe-commerce/os-extensions-metapackage to 1.0.1, together with paypal/module-braintree and see if that helps?

So:

1. First verify that adobe-commerce/os-extensions-metapackage and paypal/module-braintree are NOT mentioned in your own composer.json file, if any of those 2 are in there, remove them.
2. Run composer update adobe-commerce/os-extensions-metapackage:1.0.1 paypal/module-braintree:4.7.0 -W and see if that works
3. If that worked and the braintree module is now at version 4.7.0, verify if a future composer update wouldn't try to downgrade it again, using composer update --dry-run, if it does try to downgrade, I think you'll have to put a constraint in your own composer.json file, like "paypal/module-braintree": ">=4.7.0" to prevent that.

[hostep]

Discussed with @rjtulloh on Slack, there indeed seems to be something wrong with adobe-commerce/os-extensions-metapackage where both versions 1.0.1-p1 and 1.0.1 are valid according to composer for Magento 2.4.8(-p1), whilst the first one should only be used with Magento 2.4.7-p5 and 2.4.7-p6 if I understood it correctly.

So the solution for now is to install version 1.0.1 of adobe-commerce/os-extensions-metapackage on your Magento 2.4.8(-p1) installations.

Robert is going to see what can be done inside Adobe to try to solve this by maybe publishing newer versions of this package so composer can make a better choice in the future when trying to figure out which version of this package to install.

Also tagging @qrz-io, so he's aware of this issue.

[n2diving-dgx]

@hostep Forcing both sorta, kinda works...

$ composer update adobe-commerce/os-extensions-metapackage:1.0.1 paypal/module-braintree:4.7.0 -W --no-dev
Gathering patches for root package.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 2 installs, 7 updates, 0 removals

• Downgrading adobe-commerce/os-extensions-metapackage (1.0.1-p1 => 1.0.1)
• Upgrading paypal/module-braintree (4.6.1-p5 => 4.7.0)
• Upgrading paypal/module-braintree-core (4.6.1-p5 => 4.7.0)
• Upgrading paypal/module-braintree-customer-balance (4.6.1-p5 => 4.7.0)
• Locking paypal/module-braintree-gift-card (4.7.0)
• Upgrading paypal/module-braintree-gift-card-account (4.6.1-p5 => 4.7.0)
• Upgrading paypal/module-braintree-gift-wrapping (4.6.1-p5 => 4.7.0)
• Upgrading paypal/module-braintree-graph-ql (4.6.1-p5 => 4.7.0)
• Locking paypal/module-braintree-reward (4.7.0)
  Writing lock file
  Installing dependencies from lock file
  Package operations: 2 installs, 7 updates, 0 removals
  Gathering patches for root package.
  Gathering patches for dependencies. This might take a minute.
• Upgrading paypal/module-braintree-core (4.6.1-p5 => 4.7.0): Extracting archive
• Installing paypal/module-braintree-reward (4.7.0): Extracting archive
• Upgrading paypal/module-braintree-graph-ql (4.6.1-p5 => 4.7.0): Extracting archive
• Upgrading paypal/module-braintree-gift-wrapping (4.6.1-p5 => 4.7.0): Extracting archive
• Upgrading paypal/module-braintree-gift-card-account (4.6.1-p5 => 4.7.0): Extracting archive
• Installing paypal/module-braintree-gift-card (4.7.0): Extracting archive
• Upgrading paypal/module-braintree-customer-balance (4.6.1-p5 => 4.7.0): Extracting archive
• Upgrading paypal/module-braintree (4.6.1-p5 => 4.7.0)
• Downgrading adobe-commerce/os-extensions-metapackage (1.0.1-p1 => 1.0.1)
  2 package suggestions were added by new dependencies, use composer suggest to see details.
  [...]

But then as you predicted, reverts with the next update...

$ composer update --no-dev
Gathering patches for root package.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 7 updates, 2 removals

• Removing paypal/module-braintree-gift-card (4.7.0)
• Removing paypal/module-braintree-reward (4.7.0)
• Upgrading adobe-commerce/os-extensions-metapackage (1.0.1 => 1.0.1-p1)
• Downgrading paypal/module-braintree (4.7.0 => 4.6.1-p5)
• Downgrading paypal/module-braintree-core (4.7.0 => 4.6.1-p5)
• Downgrading paypal/module-braintree-customer-balance (4.7.0 => 4.6.1-p5)
• Downgrading paypal/module-braintree-gift-card-account (4.7.0 => 4.6.1-p5)
• Downgrading paypal/module-braintree-gift-wrapping (4.7.0 => 4.6.1-p5)
• Downgrading paypal/module-braintree-graph-ql (4.7.0 => 4.6.1-p5)
  Writing lock file
  Installing dependencies from lock file
  Package operations: 0 installs, 7 updates, 2 removals
• Removing paypal/module-braintree-reward (4.7.0)
• Removing paypal/module-braintree-gift-card (4.7.0)
  Gathering patches for root package.
  Gathering patches for dependencies. This might take a minute.
• Downgrading paypal/module-braintree-core (4.7.0 => 4.6.1-p5): Extracting archive
• Downgrading paypal/module-braintree-graph-ql (4.7.0 => 4.6.1-p5): Extracting archive
• Downgrading paypal/module-braintree-gift-wrapping (4.7.0 => 4.6.1-p5): Extracting archive
• Downgrading paypal/module-braintree-gift-card-account (4.7.0 => 4.6.1-p5): Extracting archive
• Downgrading paypal/module-braintree-customer-balance (4.7.0 => 4.6.1-p5): Extracting archive
• Downgrading paypal/module-braintree (4.7.0 => 4.6.1-p5)
• Upgrading adobe-commerce/os-extensions-metapackage (1.0.1 => 1.0.1-p1)
  Removing Paypal/BraintreeReward
  Removing Paypal/BraintreeGiftCard
  [...]

Workaround: Before updating to Magento 2.4.8-p1 edit composer.json to add two lines to the top of the "require" section for the two specific versions...
"adobe-commerce/os-extensions-metapackage": "1.0.1",
"paypal/module-braintree": "4.7.0",

Of course this means you will need to remove them before the next version upgrade. A permanent solution would be to just publish a version 1.0.2 or whatever of the os-extensions-metapackage with the correct dependencies.

[hostep]

Good to hear that indeed the issue is related to the adobe-commerce/os-extensions-metapackage package!

I would however not pin that package to a specific version, but would only constrain the braintree module to be at least version 4.7.0. That should be forward compatible for the future I believe: "paypal/module-braintree": ">=4.7.0"

@nomis11uk, @baijuncybercom: does following these steps also fix the issue for you guys?

[n2diving-dgx]

@hostep Just "paypal/module-braintree": ">=4.7.0" alone doesn't work... you need to force both... otherwise...

Your requirements could not be resolved to an installable set of packages.

[baijuncybercom]

@hostep, I got it working by adding the following two lines to composer.json and running composer update.

"adobe-commerce/os-extensions-metapackage": "1.0.1",
"paypal/module-braintree": "4.7.0",