Skip to content

[Doc] Fix storybook detection and handling on client-side navigation #10824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Jul 3, 2025

Problem

When navigating a page that does not have a storybook frontmatter, an error is thrown. Navigating to any page that should have a TOC doesn't display the TOC anymore.

How To Test

  1. make doc
  2. go to http://0.0.0.0:4000/documentation.html : there should be no error in console
  3. click the Admin link in the sidebar: it should load, display the TOC and the storybook link
  4. click the Vite link in the sidebar: there should be no error in console, it should display a TOC without storybook link

Additional Checks

  • The PR targets master for a bugfix or a documentation fix, or next for a feature

@djhi djhi added the RFR Ready For Review label Jul 3, 2025
@Madeorsk Madeorsk merged commit f166bb6 into master Jul 3, 2025
15 checks passed
@Madeorsk Madeorsk deleted the fix-documentation-storybook-detection branch July 3, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Development

Successfully merging this pull request may close these issues.

2 participants