GitHub Actions windows-2019 runner is being retired #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like ATL/MFC is not present for v142 :( |
|
To resolve this, I might just need to update all the projects to use VS 2022... |
jenatali
approved these changes
Jun 6, 2025
walbourn
force-pushed
the
runnerretirement
branch
from
006d8b9 to
c98efca
Compare
|
Turns out it was easy enough to remove all need to use legacy MFC/ATL content. |
billkris-ms
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The windows-2022 image does have v142 support, but it's missing the v142 version of Spectre-libs and more importantly, missing the v142 version of ATL/MFC. I removed the use of legacy ATL/MFC and used WRL instead where needed.