Skip to content

aux_gen: Add new guid rule to [[rule]] #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Javagedes
Copy link
Contributor

@Javagedes Javagedes commented May 9, 2025

Description

Adds a new rule, guid, that generates a content validation entry header in the aux file.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

N/A

Integration Instructions

Consumers can now use validation.type = "guid" with a guild field of [a, b, c, [d0, d1, d2, d3, d4, d5, d6, d7]

[[rule]]
symbol = "MyGuid"
validation.type = "guid"
validation.content = [0x0, 0x0, 0x0, [0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0]]

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label May 9, 2025
@Javagedes Javagedes changed the title aux_gen: Add new guid rule aux_gen: Add new guid rule to [[rule]] May 9, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.51%. Comparing base (2074cbe) to head (d7d6d1e).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #474   +/-   ##
=====================================
  Coverage   0.51%   0.51%           
=====================================
  Files        143     143           
  Lines      20715   20715           
  Branches      60      60           
=====================================
  Hits         106     106           
  Misses     20604   20604           
  Partials       5       5           
Flag Coverage Δ
MmSupervisorPkg 0.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this one you could add unit tests for? Endianness has been an occasional issue with GUIDs in the past.

@makubacki makubacki requested review from kuqin12 and kenlautner May 22, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants