MmSupervisorPkg: MmSupervisorCore consume PcdMigrateTemporaryRamFirmwareVolumes. #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:non-functional
…areVolumes. A platform has the ability to set PcdMigrateTemporaryRamFirmwareVolumes which tells the PEI core to migrate Firmware volumes from the flash part into system memory after gEfiPeiMemoryDiscoveredPpiGuid is installed. When this happens, the platform may decide to leave the original EFI_HOB_TYPE_FVs in place, and expect consumers to switch to using EFI_HOB_TYPE_FV2. Add the capability to consume EFI_HOB_TYPE_FV2 when this PCD is set. Also update the Hob consuming code to ensure that the length field of Length field of EFI_HOB_FIRMWARE_VOLUME/EFI_HOB_FIRMWARE_VOLUME2 is non zero before attempting to access/consume data from the hob.
apop5
force-pushed
the
personal/apop5/consumemigratetemp
branch
from
8a64a36 to
053cc5e
Compare
github-actions
bot
removed
the
impact:non-functional
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #489 +/- ##
========================================
- Coverage 0.51% 0.51% -0.01%
========================================
Files 143 143
Lines 20709 20720 +11
Branches 60 60
========================================
Hits 106 106
- Misses 20598 20609 +11
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kuqin12
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A platform has the ability to set PcdMigrateTemporaryRamFirmwareVolumes which tells the PEI core to migrate Firmware volumes from the flash part into system memory after gEfiPeiMemoryDiscoveredPpiGuid is installed.
When this happens, the platform may decide to leave the original EFI_HOB_TYPE_FVs in place, and expect consumers to switch to using EFI_HOB_TYPE_FV2.
Add the capability to consume EFI_HOB_TYPE_FV2 when this PCD is set. Also update the Hob consuming code to ensure that the length field of Length field of EFI_HOB_FIRMWARE_VOLUME/EFI_HOB_FIRMWARE_VOLUME2 is non zero before attempting to access/consume data from the hob.
How This Was Tested
Testing on a platform which set PcdMigrateTemporaryRamFirmwareVolumes to True.
Integration Instructions
No integration necessary.