MmSupervisorPkg: Add missing MmCoreDataHobGuid. #490
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:non-functional
MmSupervisorCore relies on the gMmCoreDataHobGuid, but it is not explicit in the need for it in the INF. Add the gMmCoreDataHobGuid to explicitly define the dependency.
apop5
force-pushed
the
personal/apop5/mmupdates
branch
from
0012c6a to
4b04e23
Compare
makubacki
reviewed
Jun 12, 2025
There was a problem hiding this comment.
Can you please mention in the commit/PR description that this the GUID was dropped in 0a59afa?
makubacki
approved these changes
Jun 12, 2025
kuqin12
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MmSupervisorCore relies on the gMmCoreDataHobGuid, but it is not explicit in the need for it in the INF.
Add the gMmCoreDataHobGuid to explicitly define the dependency.
Fixes the GUID being drop in 0a59afa.
How This Was Tested
Found while integrating into a new platform. Build failed due to unresolved external,
but build passed after adding guid to dependency.
Integration Instructions
No integration necessary.