Skip to content

test-aux: Add scope parameter for aux generation #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: add_seapkg_pecoffneglib_core_cnt_2405
Choose a base branch
from

Conversation

Javagedes
Copy link
Contributor

@Javagedes Javagedes commented Jun 17, 2025

Description

Filters the generated rules to only those rules without a scope or with the specified scope. Previously, all rules were generated which would cause test-aux to fail for symbols that did not actually exist.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Validated that we continue to compile and rules are filtered when a scope exists that is not matched.

Integration Instructions

N/A

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Jun 17, 2025
@Javagedes Javagedes force-pushed the personal/joeyvagedes/test-aux/scopes branch from 17c6267 to 11c0b2c Compare June 17, 2025 19:03
bug fix to apply a filter to the aux rules to only retain rules with no
scope or with the specified scope.
@Javagedes Javagedes force-pushed the personal/joeyvagedes/test-aux/scopes branch from 11c0b2c to ab89b75 Compare June 17, 2025 19:07
@makubacki makubacki added the type:bug Something isn't working label Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants