[webgpu] make DP4AMatMulNBitsSmallMProgram shader template #25025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qjia7 could you help to take a look? |
qjia7
reviewed
Jun 11, 2025
onnxruntime/contrib_ops/webgpu/quantization/dp4a_matmul_nbits.cc
Outdated
Show resolved
Hide resolved
onnxruntime/contrib_ops/webgpu/quantization/dp4a_matmul_nbits.cc
Outdated
Show resolved
Hide resolved
onnxruntime/contrib_ops/webgpu/quantization/dp4a_matmul_nbits.cc
Outdated
Show resolved
Hide resolved
onnxruntime/contrib_ops/webgpu/quantization/dp4a_matmul_nbits.cc
Outdated
Show resolved
Hide resolved
Co-authored-by: Jiajia Qin <jiajiaqin@microsoft.com>
qjia7
approved these changes
Jun 13, 2025
fs-eire
approved these changes
Jun 13, 2025
|
/azp run Linux QNN CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI, Windows ARM64 QNN CI Pipeline, Windows GPU Doc Gen CI Pipeline, Windows x64 QNN CI Pipeline |
|
Azure Pipelines successfully started running 5 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit refactors the
DP4AMatMulNBitsSmallMProgramto allow bothtile_size_k_vecandtile_sizeto be configured. This change allows more flexibility for performance tuning without altering the core shader functionality.There is no functional change in this commit.
Motivation and Context
This is a preparatory change to enable
DP4AMatMulNBitsSmallMProgramperformance optimization work in subsequent commits.