-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[WebNN] Fix bug in getting the first input name of a WebNN op #25027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This util GetWebNNOpFirstInputName previously accepted a WebNN op name as parameter, which will always return "input" because the key of op_inputs_map is ONNX op type. This PR fixes the bug by: - Changing the parameter of GetWebNNOpFirstInputName to ONNX op - Changing the decomposed_op_map to ONNX-to-ONNX op mapping, in order to improve the search complexity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
120a061
to
cfcd383
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline,Windows GPU WebGPU CI Pipeline,Windows OpenVINO CI Pipeline |
/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline |
/azp run Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI |
/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run Test Linux CUDA x64 Release,Test Linux TensorRT x64 Release,web_Debug / build_onnxruntime_web,web_Release / build_onnxruntime_web |
Azure Pipelines successfully started running 2 pipeline(s). |
No pipelines are associated with this pull request. |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 2 pipeline(s). |
|
This util
GetWebNNOpFirstInputName
previously accepted a WebNN op name as parameter, which will always return "input" because the key ofop_inputs_map
is ONNX op type.This PR fixes the bug by:
GetWebNNOpFirstInputName
to ONNX opdecomposed_op_map
to ONNX-to-ONNX op mapping, in order to improve the search complexity.