Skip to content

[WebNN] Fix bug in getting the first input name of a WebNN op #25027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2025

Conversation

Honry
Copy link
Contributor

@Honry Honry commented Jun 11, 2025

This util GetWebNNOpFirstInputName previously accepted a WebNN op name as parameter, which will always return "input" because the key of op_inputs_map is ONNX op type.

This PR fixes the bug by:

  • Changing the parameter of GetWebNNOpFirstInputName to ONNX op
  • Changing the decomposed_op_map to ONNX-to-ONNX op mapping, in order to improve the search complexity.

This util GetWebNNOpFirstInputName previously accepted a WebNN op
name as parameter, which will always return "input" because the
key of op_inputs_map is ONNX op type.

This PR fixes the bug by:
- Changing the parameter of GetWebNNOpFirstInputName to ONNX op
- Changing the decomposed_op_map to ONNX-to-ONNX op mapping, in
  order to improve the search complexity.
@Honry
Copy link
Contributor Author

Honry commented Jun 11, 2025

@fdwr, @guschmue, PTAL, thanks!

fdwr
fdwr previously approved these changes Jun 11, 2025
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Honry Honry force-pushed the fix-bug-in-op-check branch from 120a061 to cfcd383 Compare June 11, 2025 23:55
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fdwr
Copy link
Contributor

fdwr commented Jun 12, 2025

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline,Windows GPU WebGPU CI Pipeline,Windows OpenVINO CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Jun 12, 2025

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Jun 12, 2025

/azp run Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI

@fdwr
Copy link
Contributor

fdwr commented Jun 12, 2025

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@fdwr
Copy link
Contributor

fdwr commented Jun 12, 2025

/azp run Test Linux CUDA x64 Release,Test Linux TensorRT x64 Release,web_Debug / build_onnxruntime_web,web_Release / build_onnxruntime_web

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link

No pipelines are associated with this pull request.

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Honry
Copy link
Contributor Author

Honry commented Jun 12, 2025

image
@fdwr, could you please retrigger this failure CI? It is unrelated to this PR.

@fdwr fdwr merged commit d8096f4 into microsoft:main Jun 12, 2025
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants