Skip to content

[WebGPU-EP] Disable SubgroupMatrix uniformity checks #25028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

jchen10
Copy link
Contributor

@jchen10 jchen10 commented Jun 11, 2025

This disables the uniformity checks for SubgroupMatrix in the WebGPU EP.

This disables the uniformity checks for SubgroupMatrix in the WebGPU EP.
@jchen10
Copy link
Contributor Author

jchen10 commented Jun 11, 2025

@fs-eire @xhcao PTAL
This may help us roll Dawn as usual without manually reverting the patch.

@fs-eire
Copy link
Contributor

fs-eire commented Jun 11, 2025

Thank you for this change! It's a cleaner solution compared to adding a patch (#25011)

@fs-eire
Copy link
Contributor

fs-eire commented Jun 11, 2025

/azp run Linux QNN CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI, Windows ARM64 QNN CI Pipeline, Windows GPU Doc Gen CI Pipeline, Windows x64 QNN CI Pipeline

Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@fs-eire fs-eire merged commit 9ffc650 into microsoft:main Jun 13, 2025
83 checks passed
fs-eire added a commit that referenced this pull request Jun 17, 2025
### Description

Upgrade the version of Dawn from 991810463a to 9733be39e.

This change removes 2 patches:
- dawn_allow_non_uniform_for_subgroup_matrix_args.patch
Change #25028 is the
preferred way so that we no longer need this patch.
  
- dawn_fix_build_gcc12.patch
The fix is merged in upstream:
https://dawn-review.googlesource.com/c/dawn/+/212074

### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants