Fix some OrtStatus* leaks
#25036
Merged
Fix some OrtStatus* leaks
#25036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgchen1
requested review from
snnn,
skottmckay,
yuslepukhin and
adrianlizarraga
edgchen1
commented
Jun 12, 2025
snnn
previously approved these changes
Jun 12, 2025
yuslepukhin
reviewed
Jun 12, 2025
This reverts commit a3b92d5.
adrianlizarraga
previously approved these changes
Jun 12, 2025
skottmckay
reviewed
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OrtStatus*values should be released withReleaseStatus(). In some places this was not being done.This change adds a helper function to convert to the internal
Statustype and also release theOrtStatus*. Existing leaky usages of the helper functionToStatus()were updated.Motivation and Context
Fix
OrtStatus*leaks.