Skip to content

Revert "Improve Windows ETW callback registration and fix issues" #25055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2025

Conversation

tianleiwu
Copy link
Contributor

Description

Revert Improve Windows ETW callback registration and fix issues to unblock python packaging pipeline.

Motivation and Context

Python packaging pipeline is failing due to the changes in the PR.

@tianleiwu tianleiwu requested a review from yuslepukhin June 13, 2025 18:04
Copy link
Member

@yuslepukhin yuslepukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tianleiwu tianleiwu merged commit 0784e0a into main Jun 13, 2025
110 of 113 checks passed
@tianleiwu tianleiwu deleted the yuslepukhin/etw_revert branch June 13, 2025 20:39
@snnn
Copy link
Member

snnn commented Jun 13, 2025

We should also revert 74028e4 , because PR #24877 was for fixing crashes caused by that change. However, it is not an easy job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants