-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[MIGraphX EP][ROCm EP] Update build args to include rocm_gfx_arch input for ROCM/MIGraphX EP builds #25059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[MIGraphX EP][ROCm EP] Update build args to include rocm_gfx_arch input for ROCM/MIGraphX EP builds #25059
Conversation
ping @tianleiwu this is useful for your CI |
/azp run Linux QNN CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI, Windows ARM64 QNN CI Pipeline, Windows GPU Doc Gen CI Pipeline, Windows x64 QNN CI Pipeline |
Azure Pipelines successfully started running 5 pipeline(s). |
/azp run Linux ROCm CI Pipeline, Linux MIGraphX CI Pipeline |
Azure Pipelines successfully started running 2 pipeline(s). |
@TedThemistokleous, please run lintrunner to format. |
Reran |
/azp run Linux QNN CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI, Windows ARM64 QNN CI Pipeline, Windows GPU Doc Gen CI Pipeline, Windows x64 QNN CI Pipeline |
Azure Pipelines successfully started running 5 pipeline(s). |
@@ -30,7 +30,7 @@ | |||
sys.path.insert(0, os.path.join(REPO_DIR, "tools", "python")) | |||
import util.android as android # noqa: E402 | |||
from build_args import parse_arguments # noqa: E402 | |||
from util import ( # noqa: E402 | |||
from util import ( |
Check warning
Code scanning / lintrunner
RUFF/E402 Warning
See https://docs.astral.sh/ruff/rules/module-import-not-at-top-of-file
@@ -1074,7 +1344,7 @@ | |||
# variables. If present, use these values to define the | |||
# WinML/ORT DLL versions. | |||
build_number = os.getenv("Build_BuildNumber") # noqa: SIM112 | |||
source_version = os.getenv("Build_SourceVersion") # noqa: SIM112 | |||
sous.getenv("Build_SourceVersion") |
Check failure
Code scanning / lintrunner
RUFF/F821 Error
See https://docs.astral.sh/ruff/rules/undefined-name
winml_interop_dir = os.path.join(source_dir, "csharp", "src", "Microsoft.AI.MachineLearning.Interop") | ||
winml_interop_project = os.path.join(winml_interop_dir, "Microsoft.AI.MachineLearning.Interop.csproj") | ||
winml_interop_dir = os.path.join( | ||
source_dir, "csharp", "src", "Microsoft.AI.MachineLearning.Interop" |
Check failure
Code scanning / lintrunner
RUFF/F821 Error
See https://docs.astral.sh/ruff/rules/undefined-name
|
||
except subprocess.CalledProcessError: | ||
raise BuildError("git diff returned non-zero error code") # noqa: B904 | ||
|
||
|
||
def main(): | ||
log.debug("Command line arguments:\n {}".format(" ".join(shlex.quote(arg) for arg in sys.argv[1:]))) # noqa: G001 | ||
log.debug( | ||
"Command line arguments:\n {}".format( |
Check warning
Code scanning / lintrunner
RUFF/G001 Warning
See https://docs.astral.sh/ruff/rules/logging-string-format
Description
Allow for us to select GFX targets for build
Motivation and Context
Used by our QA but also can be leveraged by third parties to try builds for specific gfx targets and architectures
Already in our rocm7.0 testing branch via : ROCm#126