Skip to content

[MIGraphX EP][ROCm EP] Update build args to include rocm_gfx_arch input for ROCM/MIGraphX EP builds #25059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TedThemistokleous
Copy link
Contributor

Description

Allow for us to select GFX targets for build

Motivation and Context

Used by our QA but also can be leveraged by third parties to try builds for specific gfx targets and architectures

Already in our rocm7.0 testing branch via : ROCm#126

@TedThemistokleous
Copy link
Contributor Author

TedThemistokleous commented Jun 14, 2025

ping @tianleiwu this is useful for your CI
I'll be having a few more changes I need to upstream this week as well

@tianleiwu
Copy link
Contributor

/azp run Linux QNN CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI, Windows ARM64 QNN CI Pipeline, Windows GPU Doc Gen CI Pipeline, Windows x64 QNN CI Pipeline

Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@tianleiwu
Copy link
Contributor

/azp run Linux ROCm CI Pipeline, Linux MIGraphX CI Pipeline

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@tianleiwu
Copy link
Contributor

@TedThemistokleous, please run lintrunner to format.

@TedThemistokleous
Copy link
Contributor Author

TedThemistokleous commented Jun 15, 2025

Reran lintrunner init and then lintrunner -a @tianleiwu

@tianleiwu
Copy link
Contributor

/azp run Linux QNN CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI, Windows ARM64 QNN CI Pipeline, Windows GPU Doc Gen CI Pipeline, Windows x64 QNN CI Pipeline

Copy link

Azure Pipelines successfully started running 5 pipeline(s).

Comment on lines +1132 to +1133
"--apple_sysroot "
"<the location or name of the macOS platform SDK>",

Check warning

Code scanning / CodeQL

Implicit string concatenation in a list Warning

Implicit string concatenation. Maybe missing a comma?
@@ -30,7 +30,7 @@
sys.path.insert(0, os.path.join(REPO_DIR, "tools", "python"))
import util.android as android # noqa: E402
from build_args import parse_arguments # noqa: E402
from util import ( # noqa: E402
from util import (

Check warning

Code scanning / lintrunner

RUFF/E402 Warning

Module level import not at top of file.
See https://docs.astral.sh/ruff/rules/module-import-not-at-top-of-file
@@ -1074,7 +1344,7 @@
# variables. If present, use these values to define the
# WinML/ORT DLL versions.
build_number = os.getenv("Build_BuildNumber") # noqa: SIM112
source_version = os.getenv("Build_SourceVersion") # noqa: SIM112
sous.getenv("Build_SourceVersion")

Check failure

Code scanning / lintrunner

RUFF/F821 Error

winml_interop_dir = os.path.join(source_dir, "csharp", "src", "Microsoft.AI.MachineLearning.Interop")
winml_interop_project = os.path.join(winml_interop_dir, "Microsoft.AI.MachineLearning.Interop.csproj")
winml_interop_dir = os.path.join(
source_dir, "csharp", "src", "Microsoft.AI.MachineLearning.Interop"

Check failure

Code scanning / lintrunner

RUFF/F821 Error

Undefined name source\_dir.
See https://docs.astral.sh/ruff/rules/undefined-name

except subprocess.CalledProcessError:
raise BuildError("git diff returned non-zero error code") # noqa: B904


def main():
log.debug("Command line arguments:\n {}".format(" ".join(shlex.quote(arg) for arg in sys.argv[1:]))) # noqa: G001
log.debug(
"Command line arguments:\n {}".format(

Check warning

Code scanning / lintrunner

RUFF/G001 Warning

Logging statement uses str.format.
See https://docs.astral.sh/ruff/rules/logging-string-format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants