Skip to content

[webgpu] Bump version of Dawn to 9733be39e #25071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2025
Merged

Conversation

fs-eire
Copy link
Contributor

@fs-eire fs-eire commented Jun 14, 2025

Description

Upgrade the version of Dawn from 991810463a to 9733be39e.

This change removes 2 patches:

Motivation and Context

@fs-eire fs-eire requested a review from Copilot June 14, 2025 23:59
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Bumps the Dawn dependency to a newer commit and removes two now-unnecessary patches, while updating shader handling for subgroup matrix uniformity.

  • Upgrade Dawn from commit 991810463a to 9733be39e
  • Drop the dawn_allow_non_uniform_for_subgroup_matrix_args and dawn_fix_build_gcc12 patches
  • Add a diagnostic override in the WebGPU shader helper for subgroup matrix uniformity

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

File Description
onnxruntime/core/providers/webgpu/shader_helper.cc Insert disable diagnostic and related comments for subgroup matrix
cmake/patches/dawn/dawn_fix_build_gcc12.patch Remove obsolete GCC12 build-fix patch
cmake/external/onnxruntime_external_deps.cmake Remove patch applications for subgroup matrix & GCC12
cmake/deps.txt Update Dawn archive URL and checksum
Comments suppressed due to low confidence (2)

onnxruntime/core/providers/webgpu/shader_helper.cc:383

  • [nitpick] The phrase "in change https://..." is unclear; consider rephrasing to "in the change https://..." or similar for better readability.
// Dawn enforces the subgroup matrix builtin arguments to be uniform in change https://dawn-review.googlesource.com/c/dawn/+/236054

onnxruntime/core/providers/webgpu/shader_helper.cc:383

  • [nitpick] The inserted comment is indented with 4 spaces, but surrounding ss << lines use 6 spaces. Align the comment indentation to match for consistency.
// Dawn enforces the subgroup matrix builtin arguments to be uniform in change https://dawn-review.googlesource.com/c/dawn/+/236054

@guschmue guschmue added the ep:WebGPU ort-web webgpu provider label Jun 17, 2025
@fs-eire fs-eire merged commit 0699df6 into main Jun 17, 2025
89 of 93 checks passed
@fs-eire fs-eire deleted the fs-eire/upgrade-dawn-9733be39e branch June 17, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ep:WebGPU ort-web webgpu provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants