vitisai/imp/graph.cc: fix graph_save() for models with external data #25082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reading initializer data from an external data file happens on demand and uses the name of the model file to determine the directory containing the data file. Thus, when creating a new Model object in memory for the export to disk, it is important to use the path to the original model file in that object instead of the path to the model file to be exported to disk. This ensures that the original data file can still be found for reading the initializer data during the export.
schuermans-slx
force-pushed
the
fix_vitisai_graph_save_ext_data
branch
from
aba1865 to
49547f8
Compare
|
/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows x64 QNN CI Pipeline |
|
Azure Pipelines successfully started running 5 pipeline(s). |
guschmue
pushed a commit
that referenced
this pull request
Jun 17, 2025
…25082) ### Description This fixes the export of a model to disk (e.g. for debugging) in case the original model uses an external data file. Before, the external data file was not found if the model is exporter to a different directory than the original model. ### Motivation and Context Reading initializer data from an external data file happens on demand and uses the name of the model file to determine the directory containing the data file. Thus, when creating a new Model object in memory for the export to disk, it is important to use the path to the original model file in that object instead of the path to the model file to be exported to disk. This ensures that the original data file can still be found for reading the initializer data during the export. Co-authored-by: Stefan Schuermans <stefan.schuermans@amd.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the export of a model to disk (e.g. for debugging) in case the original model uses an external data file.
Before, the external data file was not found if the model is exporter to a different directory than the original model.
Motivation and Context
Reading initializer data from an external data file happens on demand and uses the name of the model file to determine the directory containing the data file.
Thus, when creating a new Model object in memory for the export to disk, it is important to use the path to the original model file in that object instead of the path to the model file to be exported to disk. This ensures that the original data file can still be found for reading the initializer data during the export.