[TRT-EP] Ignore deprecated warnings for TRT APIs #25105
Open
+22
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds MSVC-specific pragmas to suppress deprecation warnings (C4996) for TensorRT’s weakly-typed APIs on Windows builds.
- Wraps key code sections with
#pragma warning(push/disable:4996)and#pragma warning(pop)under_MSC_VER - Targets layer normalization fallback, precision flag setting, and INT8 configuration blocks
Comments suppressed due to low confidence (1)
onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc:2972
- [nitpick] Add a brief comment here (and at other pragma blocks) to explain which deprecated TensorRT APIs trigger warning C4996, so future maintainers understand the rationale for silencing it.
#if defined(_MSC_VER)
Comment on lines
+2972
to
+2974
| #if defined(_MSC_VER) | ||
| #pragma warning(push) | ||
| #pragma warning(disable : 4996) |
There was a problem hiding this comment.
Consider defining and using a helper macro (e.g., ORT_DISABLE_DEPRECATION_WARNINGS_MSVC) to wrap the push/disable:4996/pop sequence and avoid repeating identical pragmas throughout the file.
Suggested change
| #if defined(_MSC_VER) | |
| #pragma warning(push) | |
| #pragma warning(disable : 4996) | |
| ORT_DISABLE_DEPRECATION_WARNINGS_MSVC |
Copilot uses AI. Check for mistakes.
Signed-off-by: Kevin Chen <kevinch@nvidia.com>
|
/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows x64 QNN CI Pipeline |
|
Azure Pipelines successfully started running 5 pipeline(s). |
chilo-ms
approved these changes
Jun 19, 2025
|
please help address format issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In TensorRT 10.12, weakly-typed network and related APIs have been marked deprecated. Ignore these deprecated API warnings for the Windows build.