AC rendering + AC designer integration #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corinagum
reviewed
May 13, 2025
packages/devtools/src/components/AttachmentsContainer/AttachmentsContainer.styles.ts
Outdated
Show resolved
Hide resolved
corinagum
reviewed
May 13, 2025
packages/devtools/src/components/AttachmentsContainer/AttachmentsContainer.styles.ts
Outdated
Show resolved
Hide resolved
|
Converting to draft so this PR doesn't get merged yet. I need to update a base URL before merging, which I will do once that base URL is available. |
corinagum
approved these changes
May 16, 2025
aacebo
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip-test-verification
Resolves #42
This PR integrates Adaptive Card rendering and the Adaptive Card Designer into the DevTools. Both are iframed.
The iframe approach for card rendering has the drawback that the card is constrained to the iframe's dimensions. That means if a popup control is opened in the iframe, it will not bleed outside of the iframe.
The AC Designer integration builds on the initial work done by @corinagum.
Action.SubmitandAction.Executeare not handled.