Skip to content

Add support for injecting custom http.Server into HttpPlugin #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2025

Conversation

kavins14
Copy link
Contributor

@kavins14 kavins14 commented May 14, 2025

add optional server?: http.Server to the HttpPlugin constructor.

Notes:

  • http.CreateServer(this.express) takes this.express and adds it as a 'request' listener to the underlying server that's being created. src
  • express.listen is equivalent to server.listen except it creates a brand new server object (http.Server). src

@singhk97 singhk97 merged commit f06549d into microsoft:main May 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants