For TSUP, we also type-check with no-emit #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyitsaamir
requested review from
ydogandjiev,
Jesperholmbergmsft and
dclaux
as code owners
Jesperholmbergmsft
previously approved these changes
May 16, 2025
corinagum
reviewed
May 16, 2025
kavins14
approved these changes
May 19, 2025
TSUP when it might also get used in client, tsc for anything server only. I don't know if there's very many things that require tsup tbh. @aacebo i can only think of like 2 libraries that would use it right? ACs, and Teamsjs |
heyitsaamir
added a commit
that referenced
this pull request
May 22, 2025
This reverts commit a474a0a.
heyitsaamir
added a commit
that referenced
this pull request
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TS obscures type errors, so we shouldn't rely on it solely for type-checking.
egoist/tsup#609