Skip to content

Fix add text-flag for at-mention #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2025
Merged

Fix add text-flag for at-mention #249

merged 1 commit into from
Jun 6, 2025

Conversation

heyitsaamir
Copy link
Contributor

@heyitsaamir heyitsaamir commented Jun 6, 2025 •
edited
Loading

Without this, if you pass in false for addText, it would get overridden with true.

console.log(false || true) // results in true (and this is what we currently have)
console.log(false ?? true) // results in false (this is what it should be)

@corinagum corinagum merged commit a932638 into main Jun 6, 2025
5 checks passed
@corinagum corinagum deleted the aamirj/fixAddTextFlagForAtMention branch June 6, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum

@lilyydu lilyydu

@singhk97 singhk97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heyitsaamir @corinagum @lilyydu @singhk97