Enhance error handling for 403 & 404 WebApi responses #714
+226
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orbidden and 404 Not Found status codes across multiple API functions
mawasile
requested review from
mattdot,
leighatami,
ianjensenisme,
polatengin and
eduardodfmex
as code owners
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
internal/services/data_record/api_data_record.go:597
- Using errors.New with a formatting verb (%w) is incorrect; replace it with fmt.Errorf to properly wrap the error.
return errors.New("error while deleting data record. %w")
mattdot
approved these changes
Apr 23, 2025
mattdot
deleted the
mawasile/701-error-client-error-when-reading-_security_roles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to improve error handling in the API client by adding specific handlers for
NotFoundandForbiddenHTTP responses. These changes ensure that the client can provide more meaningful error messages when encountering these status codes. The main changes are grouped by theme as follows:Error Handling Enhancements:
internal/api/client.go: AddedHandleNotFoundResponseandHandleForbiddenResponsemethods to handle404 Not Foundand403 ForbiddenHTTP responses respectively.API Method Updates:
internal/services/authorization/api_user.go: Updated multiple methods (GetDataverseUsers,GetDataverseUserBySystemUserId,GetDataverseUserByAadObjectId,UpdateDataverseUser,DeleteDataverseUser,RemoveDataverseSecurityRoles,AddDataverseSecurityRoles, andGetDataverseSecurityRoles) to include403 Forbiddenand404 Not Foundin the list of acceptable status codes and to use the new error handling methods. [1] [2] [3] [4] [5] [6] [7] [8]internal/services/data_record/api_data_record.go: Updated multiple methods (getEntityDefinition,GetDataRecordsByODataQuery,GetDataRecord,GetRelationData,GetTableSingularNameFromPlural,GetEntityAttributesDefinition,GetEntityRelationDefinitionInfo,ApplyDataRecord,DeleteDataRecord, andapplyRelation) to include403 Forbiddenand404 Not Foundin the list of acceptable status codes and to use the new error handling methods. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]