Skip to content

Conversation

PromiseFru
Copy link
Collaborator

@PromiseFru PromiseFru commented Feb 29, 2024

New rule for detecting potential worksforme bugs.

Checklist

  • Type annotations added to new functions
  • Docs added to functions touched in main classes
  • Dry-run produced the expected results
  • The to-be-announced tag added if this is worth announcing

@PromiseFru PromiseFru changed the title Add new rule for detecting potential worksforme bugs [New Rule] Detect WorksForMe Bugs Feb 29, 2024
@suhaibmujahid suhaibmujahid self-requested a review February 29, 2024 13:23
Copy link
Member

@suhaibmujahid suhaibmujahid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @PromiseFru! Please see my comments.

PromiseFru and others added 2 commits March 4, 2024 11:45
Co-authored-by: Suhaib Mujahid <suhaibmujahid@gmail.com>
@PromiseFru PromiseFru requested a review from suhaibmujahid March 4, 2024 11:29
Copy link
Member

@suhaibmujahid suhaibmujahid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @PromiseFru! LGTM.

We can proceed with the merge once we successfully deploy the WorksForMe model and conduct a dry-run test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants