Skip to content

Conversation

@benjaminmah
Copy link
Contributor

Resolves #2336.

Intended to needinfo bug assignees when not all current release tracking fields are set to either affected/unaffected and an attachment is pending sec-approval.

Checklist

  • Type annotations added to new functions
  • Docs added to functions touched in main classes
  • Dry-run produced the expected results
  • The to-be-announced tag added if this is worth announcing

@benjaminmah
Copy link
Contributor Author

Still a WIP: have not added the command to search for all open bugs with sec-approval? (denoted by the TODO comment in the code).

@benjaminmah benjaminmah changed the title [New Rule] Need-info when a bug is pending sec-approval but not all tracking flags are set [New Rule] Needinfo when a bug is pending sec-approval but not all tracking flags are set Oct 17, 2024
Comment on lines 76 to 83
params = {
"include_fields": self.fields,
"resolution": "---",
"f1": self.status,
"o1": "anywords",
"n1": "1",
"v1": ",".join(["unaffected", "affected"]),
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This query seems to retrieve all open bugs with tracking for the target version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, however I noticed that bugs may have multiple versions being tracked. Is there an easy way to view all versions and their statuses aside from iterating through all versions and manually checking in the query?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

view all versions

Yes, you can return them all using the alias _custom, but you cannot query them all with that alias.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on this? How would I be able to use the alias?

but you cannot query them all with that alias.
Does this mean it is not possible to query all current release tracking fields?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot use the _custom alias to query. It can be used to specify the fields that you want to return.

Here is an example where you could use other aliases to query without specifying the exact version, instead you specify the release channel:

"f4": "cf_status_firefox_nightly",
"o4": "equals",
"v4": "---",
"f5": "cf_status_firefox_beta",
"o5": "equals",
"v5": "---",
"f6": "cf_status_firefox_release",
"o6": "equals",
"v6": "---",

@benjaminmah benjaminmah force-pushed the pending-sec-no-tracking branch from 4ea76b4 to fb9eaf4 Compare October 17, 2024 18:32
@benjaminmah benjaminmah requested review from suhaibmujahid and removed request for suhaibmujahid January 3, 2025 20:36
@benjaminmah
Copy link
Contributor Author

@suhaibmujahid does this need to be run on the vm to ensure it's correctly looking at all sec-approval bugs?

@benjaminmah benjaminmah marked this pull request as ready for review April 21, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an autonag to need-info when a bug is pending sec-approval but not all Tracking Flags are set.

2 participants