[no_severity_ni] Avoid needinfo'ing triage owners that have blocked being needinfo'd #2553
+28
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot get needinfo'd
Comment on lines
204
to
216
| def filter_bugs(self, bugs): | ||
| users_info = UserActivity(include_fields=["groups", "requests"]).check_users( | ||
| set(bug["triage_owner"] for bug in bugs.values()), | ||
| keep_active=True, | ||
| fetch_employee_info=True, | ||
| ) | ||
|
|
||
| for bug_id, bug in list(bugs.items()): | ||
| user_info = users_info[bug["triage_owner"]] | ||
| if "requests" in user_info: | ||
| if user_info["requests"]["needinfo"]["blocked"]: | ||
| del bugs[bug_id] | ||
| return bugs |
Member
There was a problem hiding this comment.
I do not think we should filter out the bugs; we should only avoid the needinfo. Also, we should decide if we want to try to find someone else to needinfo.
Contributor
Author
There was a problem hiding this comment.
I've modified the script to change the bughandler to avoid adding the bugs to the needinfo list here: a00eef2
Please let me know if this looks ok!
| user_info = users_info[bug["triage_owner"]] | ||
| if "requests" in user_info: | ||
| if user_info["requests"]["needinfo"]["blocked"]: | ||
| del bugs[bug_id] |
Member
There was a problem hiding this comment.
I would avoid having to delete items in this way. Instead, it would be clearer to limit this method to retrieve a list of triage owners that we want to filter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2053.
Adds an additional check to delete bugs where the triage owner has requested to block needinfos.
Checklist
to-be-announcedtag added if this is worth announcing