Fixed DevContainer base directory #16356
Conversation
|
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic reviewed 1 file and found no issues. Review PR in cubic.dev.
n8n-assistant
bot
added
community
|
Hey @developertom01, Thanks for the PR, We have created "GHC-2550" as the internal reference to get this reviewed. One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team. |
| @@ -2,7 +2,7 @@ | |||
| "name": "n8n", | |||
| "dockerComposeFile": "docker-compose.yml", | |||
| "service": "n8n", | |||
| "workspaceFolder": "/workspaces", | |||
| "workspaceFolder": "/workspaces/n8n", | |||
There was a problem hiding this comment.
Could you please add some description to convey how this change can fix the issue #16355 ?
It doesn't seem obvious.
There was a problem hiding this comment.
Hello @rineez
It is just a simple fix for devcontainer that eliminates this
There was a problem hiding this comment.
corepack prepare --activate && pnpm install is run in the postCreateCommand, this requires the command to be written in a base directory where package.json can be found.
There was a problem hiding this comment.
Thanks. I don't yet have privilege to approve PRs here, but I'll try to test this locally in my environment and confirm if it works.
There was a problem hiding this comment.
@rineez only n8n employees are able to approve PRs here.
…cture fix(editor): Add newline for better readability in Vite configuration
Summary
Related Linear tickets, Github issues, and Community forum posts
Fixes #16355
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)