Skip to content

fix: Fix examples for Array#includes method. #16360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aliou
Copy link

@aliou aliou commented Jun 15, 2025

Summary

This fixes the examples for the includes function in expressions.

Before:

Screenshot 2025-06-15 at 03 49 44 PM@2x Screenshot 2025-06-15 at 03 49 50 PM@2x

After:

Screenshot 2025-06-15 at 03 49 23 PM@2x Screenshot 2025-06-15 at 03 49 33 PM@2x

Related Linear tickets, Github issues, and Community forum posts

N/A

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@CLAassistant
Copy link

CLAassistant commented Jun 15, 2025

CLA assistant check
All committers have signed the CLA.

@aliou
Copy link
Author

aliou commented Jun 15, 2025

Notes for reviewers:

  • I've used fix as the scope, as I'm not updating the docs repo, but not 100% sure of which one to use.
  • Not sure if the other items of the review/merge checklist are relevant here
  • Didn't see any other methods with the same issue for array, but I didn't check other files.

Please let me know if you need any updates. Thanks!

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic reviewed 1 file and found no issues. Review PR in cubic.dev.

@n8n-assistant n8n-assistant bot added community Authored by a community member core Enhancement outside /nodes-base and /editor-ui in linear Issue or PR has been created in Linear for internal review labels Jun 15, 2025
@Joffcom
Copy link
Member

Joffcom commented Jun 15, 2025

Hey @aliou,

Thanks for the PR, We have created "GHC-2554" as the internal reference to get this reviewed.

One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team.

@dana-gill dana-gill requested a review from RomanDavydchuk June 16, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member core Enhancement outside /nodes-base and /editor-ui in linear Issue or PR has been created in Linear for internal review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants