fix(core): Prevent unauthorised workflow termination #16405
+81
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcL
changed the title
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic found 3 issues across 5 files. Review them in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
packages/cli/src/executions/__tests__/executions.controller.test.ts
Outdated
Show resolved
Hide resolved
MarcL
commented
Jun 16, 2025
n8n-assistant
bot
added
core
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
MarcL
commented
Jun 16, 2025
guillaumejacquart
previously approved these changes
Jun 17, 2025
|
✅ All Cypress E2E specs passed |
guillaumejacquart
approved these changes
Jun 17, 2025
|
|
1 similar comment
|
|
|
✅ All Cypress E2E specs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses a security vulnerability that allowed authenticated users to terminate any workflow execution, regardless of ownership. Previously, the 'stop workflow' endpoint improperly used a direct parameter reference, bypassing user-scoped authorisation. This fix ensures that only the workflow owner can stop an execution.
Related Linear tickets, Github issues, and Community forum posts
Fixes: PAY-2960
Review / Merge checklist
[ ] Docs updated or follow-up ticket created.release/backport(if the PR is an urgent fix that needs to be backported)