fix(Execute Sub-workflow Node): Don't expose the file contens when reading the workflow from a file and it's not valid JSON #16416
+33
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanDavydchuk
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
n8n-assistant
bot
added
n8n team
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic reviewed 2 files and found no issues. Review PR in cubic.dev.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the error message thrown by the Execute Workflow Node to not include the file contents when it tries to read a workflow from a file that is not actually JSON
Before:
After:
Related to node v1 and v1.1, since the option to read a workflow from a file was removed in v1.2
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-3007/execute-workflow-node-local-file-read-vulnerability
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)