Skip to content

ci: Apply backend pnpm patches on docker images as well #16436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

netroy
Copy link
Member

@netroy netroy commented Jun 17, 2025

Summary

This fixes the issue with pdfjs not working on docker images.
The latest nightly is built from this branch, so you can just test that docker image to see if the fix works.

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@netroy netroy requested a review from Joffcom June 17, 2025 13:03
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic found 1 issue across 1 file. Review it in cubic.dev

React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jun 17, 2025
@netroy netroy force-pushed the fix-pnpm-patches-in-docker-releases branch 2 times, most recently from 6234945 to 8ee08cd Compare June 17, 2025 15:48
@netroy netroy force-pushed the fix-pnpm-patches-in-docker-releases branch from 8ee08cd to 7dcc4ec Compare June 17, 2025 15:52
@netroy
Copy link
Member Author

netroy commented Jun 17, 2025

not proud of the code, but the fix works.

@netroy netroy requested review from ShireenMissi June 17, 2025 16:45
@netroy netroy added release/backport Changes that need to be backported to older releases. labels Jun 17, 2025
@@ -883,6 +883,7 @@
"@n8n/di": "workspace:*",
"@n8n/imap": "workspace:*",
"@n8n/vm2": "3.9.25",
"@napi-rs/canvas": "0.1.71",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can probably revert this and the lockfile changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team release/backport Changes that need to be backported to older releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant