-
Notifications
You must be signed in to change notification settings - Fork 31.1k
fix(Youtube Node): Correct playlist creation privacyStatus path #16451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(Youtube Node): Correct playlist creation privacyStatus path #16451
Conversation
Hey @gustavobretas Don't forget to add a test for this to make sure the field is set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cubic found 1 issue across 1 file. Review it in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai
to give specific feedback.
@@ -503,16 +503,17 @@ export class YouTube implements INodeType { | |||
snippet: { | |||
title, | |||
}, | |||
status: {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a status object alone does not have any effect because the request’s part parameter is still set to 'snippet'. The YouTube API will silently ignore the status field unless 'status' is also included in qs.part, so privacyStatus will still not be applied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing that out! That was a critical detail. The part
parameter in the request query has been updated to include 'status' in commit 1410c2f to ensure the privacyStatus
is properly processed by the YouTube API.
…privacy Fix(Youtube Node) fix(Youtube Node) Align playlist creation test with privacyStatus fix n8n-io#16442
Hey @Joffcom, Thanks for bringing that up! I've included the test updates in a separate commit. Let me know if everything looks good! |
… privacyStatus to 'private' for playlist creation
… to include 'status'
Summary
The
privacyStatus
for YouTube playlist creation was incorrectly mapped tobody.snippet.privacyStatus
. This commitcorrects the path to
body.status.privacyStatus
as per YouTube Data API v3 documentation, ensuring theprivacy setting selected in the node is respected.
Related Linear tickets, Github issues, and Community forum posts
resolves #16442
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)