test(API): Add tests for UpdateProjectDto (no-changelog) #16452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariacodes
changed the title
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic found 1 issue across 2 files. Review it in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
| @@ -204,7 +204,7 @@ export class ProjectController { | |||
| @Param('projectId') projectId: string, | |||
| ) { | |||
| const { name, icon, relations, description } = payload; | |||
| if ([name, icon, description].some((data) => typeof data === 'string')) { | |||
| if (name || icon || description) { | |||
There was a problem hiding this comment.
Using truthiness to decide whether to trigger the project update skips valid updates where description is an empty string (""), because "" is falsy. Check for undefined instead so legitimate empty values are accepted.
Suggested change
| if (name || icon || description) { | |
| if (name !== undefined || icon !== undefined || description !== undefined) { |
n8n-assistant
bot
added
core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds tests for
UpdateProjectDto.It also reverts a line introduced in Project Descriptions PR, which incorrectly assumed that the icon field is a string. While this doesn't currently break the app (since we always send all fields when updating a project, making the condition always evaluate to true), it's still misleading and technically incorrect.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/ADO-3670/tech-debt-add-tests-for-update-project-dto
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)