fix(Telegram Node): "source.on is not a function" in Telegram with binary file and Reply Markup #16458
+225
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
n8n-assistant
bot
added
n8n team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the
source.on is not a functionerror when there is a binary file and reply markup option. The issue is that the data forreply_markupis an object or an array, which causes problems when passed in the form data (see this). One of the ways to fix this is toJSON.stringifythereply_markupdataRelated Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-2974/community-issue-error-sourceon-is-not-a-function-in-telegram-with
Closes #15380
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)