Remove TOCs in favor of GitHub outlines #2825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
alolita,
austinlparker,
danielgblanco,
jpkrohling,
mtwo,
mx-psi,
svrnm and
tedsuo
as code owners
svrnm
approved these changes
Jun 23, 2025
mx-psi
approved these changes
Jun 23, 2025
reyang
approved these changes
Jun 23, 2025
arminru
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repo is getting flagged for vulnerabilities due to
markdown-toclast being released in 2017 and so having some very old transitive dependencies.Which made me go looking for alternatives to https://github.com/jonschlinkert/markdown-toc.
Which made me stumble on https://github.blog/changelog/2021-04-13-table-of-contents-support-in-markdown-files/ 🤯.
It's kind of unfortunate that this GitHub feature is a bit hidden (that I haven't noticed it in 4 years), maybe we need to start a publicity campaign for the feature 😄.
Overall, I think the downside is pretty minimal in this repo since there's only one markdown file with a TOC anyways (assets.md).