Skip to content

Conversation

@david-luna
Copy link
Contributor

Fixes #4479

Changes

Document that exporters may allow a user-agent option to append a product identifier to the exporter User Agent header. such option is only available via local var (not environment)

For non-trivial changes, follow the change proposal process.

@david-luna david-luna marked this pull request as ready for review June 23, 2025 14:16
@david-luna david-luna requested review from a team June 23, 2025 14:16
@carlosalberto
Copy link
Contributor

Maybe Collector folks should review this too @mx-psi ?

@mx-psi
Copy link
Member

mx-psi commented Jun 30, 2025

My understanding is that Collector components are not, as a general rule, bound by the spec. I guess we can add this to our coding guidelines in the Collector as well if it gets approved here to make sure it is followed

@david-luna david-luna requested a review from carlosalberto June 30, 2025 18:48
@github-actions
Copy link

github-actions bot commented Jul 8, 2025

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 8, 2025
@trentm
Copy link
Contributor

trentm commented Jul 10, 2025

not stale

@david-luna
Copy link
Contributor Author

@open-telemetry/spec-sponsors sorry for the noise but I do not know exactly who to ping for this review

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming a changelog entry will be added.

@github-actions github-actions bot removed the Stale label Jul 11, 2025
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 18, 2025
@david-luna
Copy link
Contributor Author

LGTM assuming a changelog entry will be added.

thanks @reyang for your review. Entry has been added in 3af4d2a

@github-actions github-actions bot removed the Stale label Jul 23, 2025
@david-luna
Copy link
Contributor Author

Co-authored-by: Trent Mick <trentm@gmail.com>
@david-luna david-luna requested review from a team as code owners August 21, 2025 08:39
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
@david-luna
Copy link
Contributor Author

I think this is good to merge now. @cijothomas do you have permission to merge this? If so, would you mind doing it?

@cijothomas
Copy link
Member

I think this is good to merge now. @cijothomas do you have permission to merge this? If so, would you mind doing it?

I don't. Only spec-maintainers can merge. After getting enough approvals, they typically wait couple days before merging to see any new comments show up.

(https://github.com/open-telemetry/opentelemetry-specification/blob/main/CONTRIBUTING.md#how-to-get-your-pr-merged)

@cijothomas cijothomas requested a review from dyladan August 28, 2025 15:27
@carlosalberto
Copy link
Contributor

Let's confirm with @dyladan who provided feedback recently ;)

@carlosalberto
Copy link
Contributor

Ping @dyladan

Copy link
Member

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me

@reyang reyang added this pull request to the merge queue Sep 3, 2025
Merged via the queue into open-telemetry:main with commit 4b630d8 Sep 3, 2025
6 checks passed
@david-luna david-luna deleted the enrich-user-agent-header branch September 3, 2025 15:10
@carlosalberto carlosalberto mentioned this pull request Sep 9, 2025
github-merge-queue bot pushed a commit that referenced this pull request Sep 16, 2025
### Entities

- Specify entity information via an environment variable.

([#4594](#4594))

### Common

- OTLP Exporters may allow devs to prepend a product identifier in
`User-Agent` header.

([#4560](#4560))
- ⚠️ **IMPORTANT**: Extending the set of standard attribute value types
is no longer a breaking change.

([#4614](#4614))

### OTEPs

- Clarify in Composite Samplers OTEP the unreliable threshold case.

([#4569](#4569))

---------

Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[protocol/exporter] allow SDK users to enrich the user-agent header in exporters