You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @Hofer-Julian! I would love to contribute to this. Should I start by writing an async function like generate_deactivation_script in shell_hook.rs? I have only solved some good first issues in pixi's codebase till now, so would love to hear more on how a beginner can contribute to this
I would love to contribute to this. Should I start by writing an async function like generate_deactivation_script in shell_hook.rs? I have only solved some good first issues in pixi's codebase till now, so would love to hear more on how a beginner can contribute to this
@mrswastik-robot sounds good to me. Happy to look at a draft PR as soon as you have something :)
Hi @Hofer-Julian, so I was trying to implement this, but I was having trouble finding the code @wolfv mentioned here in rattler_shell crate. There's definitely code for built-in deactivation() method on the activator object, but it doesn't appear to be a standalone deactivation() method.
For ex. I wrote this function but there isn't any deactivation() method already available:
Hey @mrswastik-robot - you are correct. There is some code missing to make it easy to deactivate environments that we need to add to rattler. However, deactivation in general is already implemented (e.g. finding all the deactivation scripts and removing env vars).
Would you be able to write the deactivation() function in rattler?
Hey @mrswastik-robot - you are correct. There is some code missing to make it easy to deactivate environments that we need to add to rattler. However, deactivation in general is already implemented (e.g. finding all the deactivation scripts and removing env vars).
Would you be able to write the deactivation() function in rattler?
sure @wolfv, I will give this a try and raise a PR in the rattler repo and link to this issue
Hi @wolfv, so I have created the PRs, after making changes in the rattler_shell crate, when I tried to use the local fork of the rattler_shell instead of the installed crate in the pixi project by providing absolute path in the Cargo.toml , I was unable to compile and run tests, mainly due to some dependency version mismatches with the rattler_conda_types crate. So, idk if the solution in the PRs will work for sure, would love to hear from your side and happy to implement further requested changes!
Activity
mrswastik-robot commentedon Apr 18, 2025
Hi @Hofer-Julian! I would love to contribute to this. Should I start by writing an async function like
generate_deactivation_script
inshell_hook.rs
? I have only solved some good first issues in pixi's codebase till now, so would love to hear more on how a beginner can contribute to thisHofer-Julian commentedon Apr 22, 2025
Please open a separate issue for that @YuanfengZhang
Hofer-Julian commentedon Apr 22, 2025
@mrswastik-robot sounds good to me. Happy to look at a draft PR as soon as you have something :)
mrswastik-robot commentedon Apr 22, 2025
Hi @Hofer-Julian, so I was trying to implement this, but I was having trouble finding the code @wolfv mentioned here in
rattler_shell
crate. There's definitely code for built-in deactivation() method on the activator object, but it doesn't appear to be a standalonedeactivation()
method.For ex. I wrote this function but there isn't any
deactivation()
method already available:wolfv commentedon Apr 23, 2025
Hey @mrswastik-robot - you are correct. There is some code missing to make it easy to deactivate environments that we need to add to
rattler
. However,deactivation
in general is already implemented (e.g. finding all the deactivation scripts and removing env vars).Would you be able to write the
deactivation()
function in rattler?mrswastik-robot commentedon Apr 23, 2025
sure @wolfv, I will give this a try and raise a PR in the rattler repo and link to this issue
deactivation()
method to Activator conda/rattler#1278generate_deactivation_script()
function in theshell_hook.rs
#3670mrswastik-robot commentedon Apr 23, 2025
Hi @wolfv, so I have created the PRs, after making changes in the
rattler_shell
crate, when I tried to use the local fork of the rattler_shell instead of the installed crate in the pixi project by providing absolute path in theCargo.toml
, I was unable to compile and run tests, mainly due to some dependency version mismatches with the rattler_conda_types crate. So, idk if the solution in the PRs will work for sure, would love to hear from your side and happy to implement further requested changes!pixi shell-hook
#3883